Skip to content

Conversation

@ogorczow
Copy link
Contributor

@ogorczow ogorczow commented Nov 7, 2025

fixed null value handling for vrf enforcement_direction, http_method and http_version

@ogorczow ogorczow marked this pull request as draft November 7, 2025 13:28
@ogorczow ogorczow marked this pull request as ready for review November 7, 2025 13:44
@ogorczow
Copy link
Contributor Author

There are 4 other occurences of null value like this:

grep -R "== null || contains"  
./modules/terraform-aci-nutanix-vmm-domain/variables.tf:      for v in values(var.controller_profile) : v.aos_version == null || contains(["unknown", "6.5", "6.6"], v.aos_version)
./modules/terraform-aci-route-control-route-map/variables.tf:      for ctx in var.contexts : ctx.action == null || contains(["deny", "permit"], ctx.action)
./modules/terraform-aci-vrf/variables.tf:    condition     = var.enforcement_direction == null || contains(["ingress", "egress"], var.enforcement_direction)
./modules/terraform-aci-ip-sla-policy/variables.tf:    condition     = var.http_method == null || contains(["get"], var.http_method)
./modules/terraform-aci-ip-sla-policy/variables.tf:    condition     = var.http_version == null || contains(["HTTP10", "HTTP11"], var.http_version)
./modules/terraform-aci-set-rule/variables.tf:      for c in var.set_as_paths : c.criteria == null || contains(["prepend", "prepend-last-as"], c.criteria)
./modules/terraform-aci-access-span-source-group/variables.tf:      for s in var.sources : s.direction == null || contains(["in", "both", "out"], s.direction) 

in nutanix-vmm-domain, route-map, set-rule and access-span-source-group. Null value is never applied to those variables, thus I do not see an reason to keep v.aos_version , ctx.action, c.criteria, s.direction with condition to check null.

@ogorczow ogorczow requested a review from juchowan November 17, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant